[codex] Improve paper corner drag responsiveness#42
Merged
jasonmadigan merged 1 commit intoMay 12, 2026
Conversation
noobydp
marked this pull request as ready for review
May 12, 2026 05:01
jasonmadigan
approved these changes
May 12, 2026
jasonmadigan
left a comment
jasonmadigan
left a comment
Collaborator
There was a problem hiding this comment.
Clean performance improvement. Local draft state with rAF coalescing during drag, commit on release -- standard pattern, well-scoped.
shanetinklenberg
pushed a commit
to shanetinklenberg/tracefinity
that referenced
this pull request
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve responsiveness when dragging paper corner handles on the trace setup screen.
The corner editor previously pushed every mouse/touch move up to the trace page via
onCornersChange, causing the parent trace page to re-render continuously during drag. This PR keeps drag updates local toPaperCornerEditor, coalesces visual updates withrequestAnimationFrame, and commits the final corner positions to the parent when the drag ends.Changes
requestAnimationFrame.PaperCornerEditorprops unchanged.Validation
npm exec tsc -- --noEmitCode and PR drafted by Codex.