Add per-object depth control#36
Merged
Merged
Conversation
Collaborator
|
Needs a rebase, but I think this looks good |
Each PlacedTool and FingerHole gains an optional depth_override that takes precedence over the bin's global cutout_depth. Resolution is fh.depth_override → polygon.depth_override → global, clamped to [5, max_depth]. Chamfer is now clamped per-feature against its own pocket depth so deep cutouts get a full chamfer and shallow ones don't punch through the floor. UI: select a placed tool to set the outline depth, or click an individual finger hole to set the hole's depth. Empty input inherits; × resets. CutoutOverlay was already interactive in the tool editor and is now reused in the bin editor. Closes #N (replace if you have an issue number) Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
jasonmadigan
force-pushed
the
pr/per-object-depth
branch
from
May 4, 2026 22:38
f154b42 to
56533d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlacedToolandFingerHolegain an optionaldepth_overridethat beats the bin's globalcutout_depth. Resolution isfh.depth_override→polygon.depth_override→ global, clamped to[5, max_depth].CutoutOverlayis now interactive in the bin editor as well as the tool editor.