fix: adjust scale_factor after corrected image downscale#19
Merged
Conversation
The corrected image (produced at 10 px/mm) was being downscaled to 2048px max dimension for storage, but scale_factor was not adjusted. This caused traced tool dimensions to be too small by the downscale ratio — e.g. a 5000px-tall corrected image shrunk to 2048px would produce tools at ~41% of their real size. _downscale_image() now returns the downscale ratio, and set_corners() divides scale_factor by it so pixel→mm conversion stays correct. Fixes tracefinity#18
Collaborator
|
thanks for spotting and fixing @715d! |
shanetinklenberg
pushed a commit
to shanetinklenberg/tracefinity
that referenced
this pull request
Jun 28, 2026
fix: adjust scale_factor after corrected image downscale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The corrected image (produced at 10 px/mm) was being downscaled to 2048px max dimension for storage, but scale_factor was not adjusted. This caused traced tool dimensions to be too small by the downscale ratio — e.g. a 5000px-tall corrected image shrunk to 2048px would produce tools at ~41% of their real size.
_downscale_image() now returns the downscale ratio, and set_corners() divides scale_factor by it so pixel→mm conversion stays correct.
Fixes #18