fix: lower cutout resize minimum from 10mm to 1mm#132
Merged
Conversation
rectangle cutout drag resize was floored at 10mm per axis (circle/square at 5mm radius), an arbitrary initial-release default. backend geometry holds at any positive size: plain cube cutter, self-clamping fillet radius, outward-only chamfer, clearance buffers polygon outlines only. extract the pinned-corner resize maths into resizeRectCutout() so the floor is unit-testable, and add backend regression tests proving 25x5mm and 1x1mm rectangle and filleted-rectangle cutouts generate valid STLs. Signed-off-by: Jason Madigan <[email protected]>
jasonmadigan
marked this pull request as ready for review
July 7, 2026 07:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resizeRectCutout,resizeRoundCutout) with unit tests, including a mutation-guard against the floor regressing.Test evidence
generate_binfor the reporter's exact 25x5mm case yields a valid STL that removes material.make lint: 0 errors.Closes #114