fix: helm chart strategy indentation and envFrom default#126
Merged
Conversation
Move strategy block from spec.template.spec (pod spec, silently ignored) to spec (deployment spec) so Recreate strategy actually takes effect. Without this, RollingUpdate deadlocks on upgrade with RWO PVC. Change envFrom default from a concrete secretRef to an empty list so fresh installs don't fail with CreateContainerConfigError. Fixes #125 Signed-off-by: Jason Madigan <[email protected]>
jasonmadigan
marked this pull request as ready for review
July 1, 2026 11:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #125. Follow-up from #79 (Helm chart contribution).
Two fixes:
strategymoved to correct indent level -- was underspec.template.spec(pod spec, silently ignored by K8s). Now underspec(deployment spec) alongsidereplicas:. Without this, upgrades default to RollingUpdate which deadlocks with the RWO PVC.envFromdefaults to[]-- was defaulting to a concretesecretRef: existing-secret, causingCreateContainerConfigErroron fresh installs. Now empty with commented examples.Test evidence
helm lint chart/passeshelm template chart/renders strategy at correct level, no envFrom block by defaultmake lintclean