Add half-grid support for bins#115
Merged
Merged
Conversation
jasonmadigan
force-pushed
the
101-half-grid-support
branch
3 times, most recently
from
June 27, 2026 15:59
8e6298f to
6925736
Compare
jasonmadigan
marked this pull request as ready for review
June 27, 2026 16:21
jasonmadigan
force-pushed
the
101-half-grid-support
branch
2 times, most recently
from
June 27, 2026 20:00
0b5d063 to
dd7a034
Compare
- grid_x/grid_y accept 0.5-unit increments (e.g. 3.5x2.5 bins) - half_grid_base toggle: 21mm baseplate cells instead of 42mm - magnets incompatible with half-grid (forced off at model layer, toggle disabled in UI) - auto-size snaps to 0.5u when half-grid on, 1u when off - fractional bin boundary lines visible in editor - frontend: 0.5-step sliders, half-grid toggle, half-grid lines - 20 new backend tests Signed-off-by: Jason Madigan <[email protected]>
jasonmadigan
force-pushed
the
101-half-grid-support
branch
from
June 27, 2026 20:01
dd7a034 to
a78049a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101
What
Adds half-size grid support:
grid_x/grid_yaccept 0.5-unit increments (e.g. 3.5×2.5), validated at the schema levelhalf_grid_basetoggle switches the bottom baseplate from 42mm to 21mm cells for finer positioning on baseplatesHow
Backend:
BinParams.grid_x/grid_ychanged frominttofloatwith 0.5-increment validator_base_cell_layout()computes cell centres and widths for any cell size, handling partial trailing cells for fractional gridshalf_grid_baseis enabledtarget_grid_x/target_grid_yalso updated to floatFrontend:
Test evidence
185/185 backend tests pass (16 new in
test_half_grid.py). TypeScript type check clean.New tests cover: validation (valid/invalid increments, boundaries), cell layout (full and half grid, integer and fractional), STL generation (fractional dimensions, half-grid base), magnet placement, stacking lip, and splitting with fractional grids.