feat: Add Partial Bins option#112
Conversation
Add webhook callbacks for completed bin generation (tracefinity#112)
|
thanks @gr3enk, I'll try to review this this weekend |
|
All good. Added one more feature to retain the bin wall on cutout parts. 
|
|
Real Life Tests done aswell ☑️😄 
|
jasonmadigan
left a comment
jasonmadigan
left a comment
There was a problem hiding this comment.
Changes requested
-
stl_generator_manifold.py:split_bin()uses_effective_grid_span()for the diagonal fit check, but in connect mode the manifold keeps the full grid footprint. the effective span is only correct for non-connect pieces. connect mode needs to check against the full grid size, otherwise it falsely passes the bed-size check. -
all-false
partial_bins_valuesgenerates empty/near-empty geometry. needs a guard. either UI prevents deselecting every cell, or backend rejects the request. -
BinConfigurator.tsx: duplicate insert controls. the existing "Insert Height"/"Insert Fit" block wasn't removed when the new copy was added inside the Partial Bins section. both render when insert is enabled, so you get 2x of each. -
(edge case, non-blocking) embossed text labels placed in a disabled cell area become floating geometry in the STL. pre-existing limitation exposed by this feature, not a regression. flagging for awareness.
|
great job @gr3enk happy to merge this after we get the above fixed up. |
|
Thanks for the Review @jasonmadigan. Changes are done. Do you want me to track the floating text issue in an github issue? |
|
@jasonmadigan my IDE changed the whole formatting of some changed files. Reverted that now so the pr is not so bloated with diffs. Should be ready to go now. |
|
Wow! Awesome work guys. Thank you! |
Add webhook callbacks for completed bin generation (tracefinity#112)
Let external services provide a webhook_url and webhook_metadata when
creating a trace session via POST /api/upload. After bin generation
succeeds (session-based or bin-based), a POST is delivered to the
webhook URL with the generation result and the original metadata.
Changes:
- New webhook_url / webhook_metadata fields on Session, Tool, and BinModel
- New webhook_service.py: fire-and-forget HTTP POST in daemon thread
- POST /api/upload accepts optional webhook_url + webhook_metadata form fields
- PATCH /api/sessions/{id} can update webhook fields
- Save-tools copies session webhook onto every created library tool
- Bin creation inherits the first tool's webhook
- Session- and bin-generate endpoints fire the webhook after a successful build
- Docs: new Webhooks section in api.md, cross-reference in uploading-photos.md
3 participants
Adds following options to the bin editor:
Partial Bins(Toggle): Enables the Partial Bins sub menu.Connect Base(Toggle): If enabled the model will be connected with the base plate.This feature can save a lot of filament for big and sturdy objects that doesn't need a complete filled out bin. See:
Closes #106
With 'Connect Base' option enabled:
The exported objects came out like this:
