Fix raised rim when stacking lip is disabled#103
Merged
jasonmadigan merged 1 commit intoJun 22, 2026
Conversation
noobydp
marked this pull request as ready for review
June 22, 2026 04:56
jasonmadigan
approved these changes
Jun 22, 2026
Collaborator
|
thanks @noobydp |
shanetinklenberg
pushed a commit
to shanetinklenberg/tracefinity
that referenced
this pull request
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a follow-up bug from PR #83.
PR #83 added
rim_unitsso the stacking lip can be raised above the bin floor face, letting a stacked bin clear tools that protrude above shallow-bin cutouts. The original UI only exposed "Raise Lip" whenstacking_lipwas enabled, and the feature was described as moving the stacking lip onto a raised hollow collar.However, the backend generator still honored
rim_unitseven whenstacking_lipwas false. That meant a saved or stale config could silently generate a raised perimeter wall even though the stacking lip was disabled and the UI no longer showed the control. This maderim_unitshidden state affect STL geometry outside the feature's intended scope.This change:
rim_unitsin STL generation unlessstacking_lipis enabledrim_unitswhen the stacking lip toggle is turned off in the configuratorrim_unitsdoes not change generated volume when stacking lip is disabledCode and PR drafted with Codex
Testing:
python -m pytest backend/tests/test_raise_lip.py backend/tests/test_max_cutout_depth.pyfrontend\node_modules\.bin\vitest.cmd run frontend/src/components/BinConfigurator.test.ts --config frontend/vitest.config.ts