Repository navigation
🐛 fix: install the nab workspace, accept dispatched tag checks - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two regressions in 5.0.0 that the consumer migration turned up.
nab-git-commitinstalled only the top-levelnabpackage. nab's main branch is a workspace whose sub-packages pin an unreleased 0.0.23.dev0, so the install failed withno version of nab-resolver==0.0.23.dev0. All six packages now install from the same commit, the sub-packages through#subdirectory=. I checked this against nab main's current tip.check-tagged-sourcerejected manual dispatches from main. 5.0.0 required the tag to equalGITHUB_SHA, which breaks a retry dispatched from main with ataginput, such as action-pre-commit-uv's. The tag now comes frominputs.tagwhen present. On a tag ref the strict rule still applies. On other events the checked-out HEAD must be the tag's commit and onmain, which is what 4.0.1 enforced.validate-python-releasestays strict, since nothing dispatches it.