Repository navigation
fix : use effectiveTodayStr instead of localTodayStr for resolvedTodayDate in streak calculation - #18
Closed
tmdeveloper007 wants to merge 1 commit into
Closed
tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
…Date in streak calculation
github-actions
Bot
added
the
needs-details
|
👋 Hey @tmdeveloper007, it looks like you didn't use our PR template! The section Please update your PR description to include all required sections so we can review this properly:
You can find the full template in CONTRIBUTING.md. Just edit your PR description and the |
|
👋 Hey @tmdeveloper007! Unfortunately, this PR has been automatically closed because the referenced issue #8683 does not exist (or was deleted). To resolve this, please do the following:
Please link a valid open issue before this PR can be reviewed. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Fixed an unconditional overwrite of
resolvedTodayDateincalculateStreakinlib/calculate.ts. The variable was initialized tolocalTodayStrbut should be initialized toeffectiveTodayStrto correctly reflect vacation-adjusted dates.Changes Made
lib/calculate.ts: Changedlet resolvedTodayDate = localTodayStr;tolet resolvedTodayDate = effectiveTodayStr;incalculateStreakImpact it Made
Closes
Closes #8683
Note
Please assign this PR to the
tmdeveloper007account.