Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: agorapulse/testing-libraries
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: tlefevre/testing-libraries
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Feb 25, 2019

  1. Fixes a problem with Windows file separator in Fixt 

    File.separator is used in a regex, but the Windows filesystem separator
is a backslash which is an escape character in a regex. There is no
subsequent character and that causes an exception.

Redid Fixt.java as Fixt.groovy as it's in the src/main/groovy folder.

Switched to using FileSystems.default.getPath to resolve the location.
Sidesteps the issue completely, revert to the old code to see an example
of how it fails.

Excluded UnnecessaryGString from Codenarc configuration as there is no
such thing as unnecessary gstring. Double quoted strings are still just
java.lang.String if there's no interpolation in them.  Ref: 4.4 of the
groovy docs.

Extended the spec to test with both a unix and a windows file separator
    Thomas Lefèvre authored and Thomas Lefèvre committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    91b7bd0 View commit details
    Browse the repository at this point in the history
Loading