Skip to content

Better detection for platform OS #4

Open

Description

@mhartington

Since lua LSP has predictable platforms it builds to, you could do a conditional check and set the bin location

local bin_location = jit.os

if jit.os == 'osx' then 
  local bin_location = 'macOS'
elseif jit.os == 'linux' then --or what ever the value returned by linux
    local bin_location = 'Linux'
....

Just some ideas

Activity

  1. martini97 commented on Dec 8, 2020

    @martini97
  2. wantyapps commented on Mar 3, 2021

    @wantyapps

    This is what I do in my pr! Please note that the macOS jit.os value is in uppercase. Not "osx", but "OSX".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions