fix(ci): Fix failing CI dependencies due to Werkzeug and pytest_django (getsentry#1124)

ahmedetefy · sentry-bot · web-flow · commit b9c5cd4e06b5 · 2021-06-01T20:44:23.000+02:00
* fix(ci): Pin trytond werkzeug dependency to Werkzeug&lt;2.0

* Pinned Wekzeug frequence for flask

* Pinned pytest-django

* Fixed missing DB django tests issue

* fix: Formatting

* Allowed database access to postgres database in django tests

* Added hack to set the appropriate db decorator

* Converted string version into tuple for comparison

* fix: Formatting

* Handled dev versions of pytest_django in hack

Co-authored-by: sentry-bot &lt;markus+ghbot@sentry.io&gt;
diff --git a/tests/integrations/django/test_basic.py b/tests/integrations/django/test_basic.py
@@ -1,6 +1,7 @@
 from __future__ import absolute_import
 
 import pytest
+import pytest_django
 import json
 
 from werkzeug.test import Client
@@ -21,6 +22,19 @@
 
 from tests.integrations.django.myapp.wsgi import application
 
+# Hack to prevent from experimental feature introduced in version `4.3.0` in `pytest-django` that
+# requires explicit database allow from failing the test
+pytest_mark_django_db_decorator = pytest.mark.django_db
+try:
+    pytest_version = tuple(map(int, pytest_django.__version__.split(".")))
+    if pytest_version > (4, 2, 0):
+        pytest_mark_django_db_decorator = pytest.mark.django_db(databases="__all__")
+except ValueError:
+    if "dev" in pytest_django.__version__:
+        pytest_mark_django_db_decorator = pytest.mark.django_db(databases="__all__")
+except AttributeError:
+    pass
+
 
 @pytest.fixture
 def client():
@@ -245,7 +259,7 @@ def test_sql_queries(sentry_init, capture_events, with_integration):
 
 
 @pytest.mark.forked
-@pytest.mark.django_db
+@pytest_mark_django_db_decorator
 def test_sql_dict_query_params(sentry_init, capture_events):
     sentry_init(
         integrations=[DjangoIntegration()],
@@ -290,7 +304,7 @@ def test_sql_dict_query_params(sentry_init, capture_events):
     ],
 )
 @pytest.mark.forked
-@pytest.mark.django_db
+@pytest_mark_django_db_decorator
 def test_sql_psycopg2_string_composition(sentry_init, capture_events, query):
     sentry_init(
         integrations=[DjangoIntegration()],
@@ -323,7 +337,7 @@ def test_sql_psycopg2_string_composition(sentry_init, capture_events, query):
 
 
 @pytest.mark.forked
-@pytest.mark.django_db
+@pytest_mark_django_db_decorator
 def test_sql_psycopg2_placeholders(sentry_init, capture_events):
     sentry_init(
         integrations=[DjangoIntegration()],
diff --git a/tox.ini b/tox.ini
@@ -104,6 +104,7 @@ deps =
     django-{1.6,1.7}: pytest-django<3.0
     django-{1.8,1.9,1.10,1.11,2.0,2.1}: pytest-django<4.0
     django-{2.2,3.0,3.1}: pytest-django>=4.0
+    django-{2.2,3.0,3.1}: Werkzeug<2.0
     django-dev: git+https://github.com/pytest-dev/pytest-django#egg=pytest-django
 
     django-1.6: Django>=1.6,<1.7
@@ -203,7 +204,7 @@ deps =
     trytond-5.0: trytond>=5.0,<5.1
     trytond-4.6: trytond>=4.6,<4.7
 
-    trytond-4.8: werkzeug<1.0
+    trytond-{4.6,4.8,5.0,5.2,5.4}: werkzeug<2.0
 
     redis: fakeredis
 
@@ -303,9 +304,7 @@ commands =
 
     ; https://github.com/pytest-dev/pytest/issues/5532
     {py3.5,py3.6,py3.7,py3.8,py3.9}-flask-{0.10,0.11,0.12}: pip install pytest<5
-
-    ; trytond tries to import werkzeug.contrib
-    trytond-5.0: pip install werkzeug<1.0
+    {py3.6,py3.7,py3.8,py3.9}-flask-{0.11}: pip install Werkzeug<2
 
     py.test {env:TESTPATH} {posargs}
 
