fix(aws-lambda): Change function handler name to 'x.y' (getsentry#1107)

ahmedetefy · web-flow · commit b7b5c03ef326 · 2021-05-06T16:07:55.000+02:00
Fix for AWS Function Handler name to be in the format of filename.function-name because
passing paths as function names is giving us import errors from AWS Lambda
diff --git a/scripts/build_awslambda_layer.py b/scripts/build_awslambda_layer.py
@@ -52,7 +52,7 @@ def create_init_serverless_sdk_package(self):
         sentry-python-serverless zip
         """
         serverless_sdk_path = (
-            f"{self.packages_dir}/sentry_sdk/" f"integrations/init_serverless_sdk"
+            f"{self.packages_dir}/init_serverless_sdk"
         )
         if not os.path.exists(serverless_sdk_path):
             os.makedirs(serverless_sdk_path)
diff --git a/tests/integrations/aws_lambda/client.py b/tests/integrations/aws_lambda/client.py
@@ -51,7 +51,7 @@ def build_no_code_serverless_function_and_layer(
                 }
             },
             Role=os.environ["SENTRY_PYTHON_TEST_AWS_IAM_ROLE"],
-            Handler="sentry_sdk.integrations.init_serverless_sdk.sentry_lambda_handler",
+            Handler="init_serverless_sdk.sentry_lambda_handler",
             Layers=[response["LayerVersionArn"]],
             Code={"ZipFile": zip.read()},
             Description="Created as part of testsuite for getsentry/sentry-python",

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ def create_init_serverless_sdk_package(self):`
`52`	`52`	`sentry-python-serverless zip`
`53`	`53`	`"""`
`54`	`54`	`serverless_sdk_path = (`
`55`		`- f"{self.packages_dir}/sentry_sdk/" f"integrations/init_serverless_sdk"`
	`55`	`+ f"{self.packages_dir}/init_serverless_sdk"`
`56`	`56`	`)`
`57`	`57`	`if not os.path.exists(serverless_sdk_path):`
`58`	`58`	`os.makedirs(serverless_sdk_path)`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ def build_no_code_serverless_function_and_layer(`
`51`	`51`	`}`
`52`	`52`	`},`
`53`	`53`	`Role=os.environ["SENTRY_PYTHON_TEST_AWS_IAM_ROLE"],`
`54`		`- Handler="sentry_sdk.integrations.init_serverless_sdk.sentry_lambda_handler",`
	`54`	`+ Handler="init_serverless_sdk.sentry_lambda_handler",`
`55`	`55`	`Layers=[response["LayerVersionArn"]],`
`56`	`56`	`Code={"ZipFile": zip.read()},`
`57`	`57`	`Description="Created as part of testsuite for getsentry/sentry-python",`