Fix commits pagination#344
Merged
timols merged 1 commit intotimols:masterfrom Aug 13, 2019
ctabin:fix-commits-pagination
Merged
Fix commits pagination#344timols merged 1 commit intotimols:masterfrom ctabin:fix-commits-pagination
timols merged 1 commit intotimols:masterfrom
ctabin:fix-commits-pagination
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
In the
GitLabAPI.getCommits(projectId, pagination, branchOrTag), the pagination argument is ignored when invoking the extendedgetCommit` method. Since there is no warning about that, not all the commits will come back.A temporary fix in 4.0.1 is to directly call
getCommits(projectId, pagination, branchOrTag, null).Best regards !
Cédric