Conversation
this field is required for the 'add user' gitlab api call
TL;DR is that I've added a 'createUser' function that take a GitlabUser as an argument and will create the user provided you don't break any of the API rules. Have pondered adding checkers so at least the 'exception' is more useful (because the api certainly is not).
|
Generally looks good, but whitespace formatting/changes are kinda heinous. Would you mind resolving? Let me know if the style/formatting is not obvious and I can give more specific details. |
|
I'll try to resolve - it was frightening to see, tbh. |
will create the user provided you don't break any of the API rules. Have pondered adding checkers so at least the 'exception' is more useful (because the api certainly is not). See JavaDoc comment for more details.
|
Do I need to resubmit the pull request? I've got a much more sane version of that checked in now... sorry about that, is one of those things one does at work: click, click, click, oh that looks terrible. Sorry about that. |
|
Please see pr #21, this createUser method does not take all possible fields as documented @http://doc.gitlab.com/ce/api/users.html I think having this variant of createUser is fine (one that takes a GitlabUser obj, but the method should be renamed to note the limited properties it applies) |
|
Agree |
|
Looks like there is a merge conflict - if you get a chance, would you mind resolving the conflicts by merging the latest upstream changes in the master branch into this branch? |
|
You can actually ignore this pull request if you want. The subsequent request that contained the full user CRUD is a better checkin than mine. |
|
Ok cool, thanks @bm-jasonc. I'm going to close this request. |
4 participants
So, sorry that Eclipse ruined the whitespace and made this patch look crazier that it should. I can re-do the work if you'd prefer. Detailed notes are in the check-ins on the files themselves.