Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughDocumentation use-case layouts now use responsive grids and fluid card sizing. Overview content width and the documentation home column adjust at smaller viewport sizes. ChangesDocumentation responsive layout
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This PR changes documentation page layout for improved mobile responsiveness, with no actionable merge-blocking risk remaining after normal checks and review. Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
docs/content/use-cases/overview.mdxESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. docs/src/components/DocsGetStarted.tsxESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. docs/src/components/UseCaseBranchCard.tsxESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@kavix let's squash and force push so that PR will only have a single commit. We follow a single commit per PR rule. Also let's address existing code review comments |
bf613cc to
54d819d
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
1 similar comment
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
939c722 to
54d819d
Compare
done! |
54d819d to
4c2a204
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Signed-off-by: Kavindu Sachinthe <[email protected]>
c719ce3 to
ad0d0db
Compare
|
Hi @brionmario @ThaminduDilshan, I’ve addressed the requested changes, removed the unrelated CSS changes, moved the component styling to MUI sx props, and squashed the PR into a single commit as requested. Could you please take another look when you have a chance? Thanks! |
| max-width: none; | ||
| } | ||
|
|
||
| .docs-doc-id-use-cases\/overview .theme-doc-markdown.markdown { |
There was a problem hiding this comment.
@kavix Why did we had the CSS here?
Adding a max with like this would be a problem for larger screens.
Can we avoid this and go for a flex layout?
The implementation should work for 1, 2, 3 or any other number of usecase cards.
Use a <Grid> component if requrired.
Purpose
Make the docs home page and use-cases section responsive on mobile, removing the left-heavy layout and using the available width more effectively.
Approach
Screenshots
Desktop Flow
Mobile Flow
Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks
Summary by CodeRabbit