LLEXT: convert most remaining Module Adapter drivers#9453
Merged
kv2019i merged 15 commits intothesofproject:mainfrom Sep 18, 2024
Merged
LLEXT: convert most remaining Module Adapter drivers#9453kv2019i merged 15 commits intothesofproject:mainfrom
kv2019i merged 15 commits intothesofproject:mainfrom
Conversation
lyakh
requested review from
a team,
abonislawski,
dbaluta,
iuliana-prodan,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart,
singalsu and
tlissows
as code owners
lyakh
force-pushed
the
llext-stub
branch
3 times, most recently
from
dc5b5e7 to
e07541c
Compare
lgirdwood
approved these changes
Sep 10, 2024
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
A future update could fix the include paths to remove the ../../../
Collaborator
Author
|
@wszypelt as far as I can see two TGL QB failures cannot be related? |
kv2019i
reviewed
Sep 11, 2024
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
See question inline about putting board file changes togehter with module changes.
| CONFIG_MODULES=y | ||
| CONFIG_LIBRARY_BASE_ADDRESS=0xa0688000 | ||
|
|
||
| # Modular by default components. Compile-tested but usually not needed at run-time |
Collaborator
There was a problem hiding this comment.
Hmm, why are Intel board file changes and generic module code changes in the same commit? Especially as the config change is done to only some targets (e.g. not even all ace targets), so a commit explaining the reasoning would be nice.
Add support for LLEXT building to RTNR. Only building in a stub configuration is supported, linking with a prebuilt library should be implemented separately. So far no platform is switched to building RTNR as a module. Signed-off-by: Guennadi Liakhovetski <[email protected]>
In certain configurations "asm" breaks compilation, use "__asm__" instead. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add support for LLEXT building to google_ctc_audio_processing. Only building in a stub configuration is supported, linking with a prebuilt library should be implemented separately. Signed-off-by: Guennadi Liakhovetski <[email protected]>
zephyr/CmakeLists.txt contains multiple conditional blocks with the same condition, that can be trivially merged. This patch does that. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add support for LLEXT building to crossover. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add support for LLEXT building to selector. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add support for LLEXT building to dcblock. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add support for LLEXT building to dts. Only building in a stub configuration is supported, linking with a prebuilt library should be implemented separately. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add support for LLEXT building to igo_nr. Only building in a stub configuration is supported, linking with a prebuilt library should be implemented separately. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add support for LLEXT building to tdfb. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add support for LLEXT building to multiband_drc. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add support for LLEXT building to aria. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add support for LLEXT building to mfcc. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add support for LLEXT building to google_rtc_audio_processing. Only building in a stub configuration is supported, linking with a prebuilt library should be implemented separately. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Member
|
@lyakh jenkins looks fine, the not runs are due to v2.11 stressing runs. |
Add support for LLEXT building to mux. Signed-off-by: Guennadi Liakhovetski <[email protected]>
lgirdwood
approved these changes
Sep 17, 2024
lyakh
changed the title
kv2019i
approved these changes
Sep 18, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts most remaining Module Adapter drivers to LLEXT modules without activating modular build for them. This also means that these modules haven't been tested for loading and therefore can use unexported symbols, in which case suitable
EXPORT_SYMBOL()calls will have to be added