Working draft for Event subsystem - #1
Closed
localheinz wants to merge 675 commits into
Closed
Conversation
localheinz
force-pushed
the
event
branch
2 times, most recently
from
October 5, 2019 21:56
cc93935 to
da1afec
Compare
rpkamp
reviewed
Oct 6, 2019
|
|
||
| public function is(Type $other): bool | ||
| { | ||
| return $other->asString() === $this->asString(); |
There was a problem hiding this comment.
This seems prone to collision with other types.
Maybe change to get_class($other) === get_class($this) && $other->asString() === $this->asString()?
Note that in PHP the object has access to the $name property of $other since it's in the same class, so this would also work:
return get_class($other) === get_class($this) && $other->name === $this->name;
Owner
There was a problem hiding this comment.
As this class will vanish (see below), this point is probably mute.
Regarding property access: Yes, we are aware of that but I consider it bad software design. The asString is part of the public API, the existence of the property name is a (private) implementation detail.
| { | ||
| public static function type(Type $type): self | ||
| { | ||
| return new self(\sprintf('Type "%s" not supported', $type->asString())); |
There was a problem hiding this comment.
I would add the class name of the subscriber here to create a bit of context: Event subscriber "Foo\Bar\BazSubscriber" does not support events of type "blah"
Owner
There was a problem hiding this comment.
Good idea.
Even though this should technically be almost impossible to ever trigger, given that the dispatcher uses the same method to find out what types of events to send to this subscriber.
|
Really awesome that you're implementing this 👍 🚀 |
localheinz
force-pushed
the
event
branch
5 times, most recently
from
October 8, 2019 14:48
bb76c8e to
0c15889
Compare
localheinz
commented
Oct 10, 2019
localheinz
commented
Oct 12, 2019
rpkamp
reviewed
Oct 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
============================================
+ Coverage 83.56% 84.18% +0.61%
- Complexity 4501 4733 +232
============================================
Files 218 260 +42
Lines 11030 11745 +715
============================================
+ Hits 9217 9887 +670
- Misses 1813 1858 +45
Continue to review full report at Codecov.
|
rpkamp
reviewed
Oct 28, 2019
localheinz
force-pushed
the
event
branch
8 times, most recently
from
November 14, 2019 15:52
ecd9405 to
5d15372
Compare
localheinz
force-pushed
the
event
branch
2 times, most recently
from
December 27, 2019 10:49
9fd3d89 to
252d6f3
Compare
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Fixes #68. Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Fixes #32. Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Remove redundant formatter Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Co-authored-by: Andreas Möller <[email protected]> Co-authored-by: Arne Blankerts <[email protected]>
Owner
|
This PR is closed as it was merged by other means. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
phpunitBuild Status