Fixed attachment type comparison problem#3
Closed
brimcfadden wants to merge 1 commit into
Closed
Conversation
…e.MIMEBase and changed the docstring to more accurately describe the nature of the attachments parameter.
Owner
|
Fantastic - pulled. Thanks!! |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While 99e2f70 introduced setup.py and "made attachments work," there was an error in the code.
I opened an issue (#2) which details the following error:
You can see the whole stack trace on the issue page.
For some reason, the scope of the original
import emaildoesn't allow that attribute to be seen. I've fixed the problem. I'm guessing that joshourisman was passing in tuples while testing (so the code never executed the statementisinstance(attachment, email.mime.base.MIMEBase), or else his version of Python is different from mine (which is 2.6.5 on Linux) and theemailpackage is differs. Python packaging is still a bit enigmatic to me.I also updated the docstring description for the
attachmentsparameter, because it was wrong.I am able to send e-mails with attachments using my edits. I didn't attempt to use
MIMEBaseobjects because I haven't used them before and that doesn't seem like it would be an issue. You can close the issue I opened if you pull this commit.