Repository navigation
optional logging - level and custom handler - #16
Conversation
Co-Authored-By: rbdubz3 <[email protected]>
Co-Authored-By: rbdubz3 <[email protected]>
Co-Authored-By: rbdubz3 <[email protected]>
Co-Authored-By: rbdubz3 <[email protected]>
|
sorry guys - GitHub neophyte - noticed another consistency change but not sure how to get the PR to pull the latest from my fork master .. I basically changed the actual param names 'log_level' to match in both constructor and set_loglevel method |
|
See https://github.com/tfriedel/python-lightify/pull/16/files - it looks like you have changed that successfully. Does it display all your changes? Thanks! |
|
@OleksandrBerchenko - yeah those look good .. think we are clean and consistent now with comments - thanks |
|
@tfriedel Hi! Are you waiting for me to test it with Home Assistant logger, or am I waiting when it's merged first? :) |
|
@OleksandrBerchenko - curious on the support for 'scenes' - is there any way to invoke the built-in dynamic scenes from the Sylvania mobile app using the python library - Fireplace, Ocean, Candy, Polar Light, etc ? |
|
@rbdubz3 I don't know, sorry. |
|
@OleksandrBerchenko I merged it now. Can you please test it with the HA logger? |
|
1. In general, you don't need to pass HA log handler into Lightify class to control the logging. Everything already works as expected. For example, you may have in 2. The only issue is that you can't set a less severe level than the one from Lightify: In other words, if by default you have P.S. @tfriedel Let me know when you had a chance to go through my comments in #13. When we finalize all the changes, you will need to trigger a new build on Pypi. Thanks! |
added optional logging features: