Repository navigation
Use only bytes in build commands - #1
Merged
Merged
Conversation
This commit makes sure, that only byte type objects are added to struct obj. The old try and except was failing in newer python versions.
Owner
|
thanks! I will test it soon with my home assistant installation and make a pull request there. |
Author
|
Okay, I'm also working on adding the group features there. :) |
Author
|
w8 before you make the pr to HA, because I just realized, it will be super handy to add an |
Author
|
hmmm now I realized, when I would add everything that I need to the |
Author
|
okay, I think I made up my mined. I checked the hue implementation and there it is handled within HA itself, so I believe its best to follow this as a reference. Thus no further changes to python_lightify needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes sure, that only byte type objects are added with struct
obj. The old try and except was failing in newer python versions.
I've tested it with python3.5 and python3.6 and it seems to work. With python2.7 it doesn't, but I think that's not a problem.