Add ArangoDB Container support#221
Add ArangoDB Container support#221SergeyPirogov merged 15 commits intotestcontainers:masterfrom nshine:master
Conversation
|
Thanks! Celery definitely needs this one for its integration suite. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #221 +/- ##
==========================================
+ Coverage 86.18% 86.52% +0.34%
==========================================
Files 26 27 +1
Lines 702 720 +18
Branches 65 65
==========================================
+ Hits 605 623 +18
Misses 76 76
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The failing tests seem to be the consequence of a recent sphinx change (sphinx-doc/sphinx#10474). You should be able to fix it by changing |
|
Fixed |
tillahoffmann
left a comment
There was a problem hiding this comment.
Looks great! A few small comments.
Co-authored-by: Till Hoffmann <[email protected]>
Co-authored-by: Till Hoffmann <[email protected]>
Co-authored-by: Till Hoffmann <[email protected]>
Co-authored-by: Till Hoffmann <[email protected]>
|
Thanks for your review. updated. |
tillahoffmann
left a comment
There was a problem hiding this comment.
Few more thoughts.
|
Hi, all resolved. |
|
@tillahoffmann - I will appreciate if you could merge and generate a new release. |
|
Hi @thedrow / @SergeyPirogov any chance you can step in and approve&release this one ? |
|
@nshine thank you |
|
Hi @SergeyPirogov |
ArangoDB -> https://www.arangodb.com