Skip to content

Add ArangoDB Container support#221

Merged
SergeyPirogov merged 15 commits intotestcontainers:masterfrom
nshine:master
Jun 14, 2022
Merged

Add ArangoDB Container support#221
SergeyPirogov merged 15 commits intotestcontainers:masterfrom
nshine:master

Conversation

@nshine
Copy link
Copy Markdown
Contributor

@nshine nshine commented Jun 5, 2022

@thedrow
Copy link
Copy Markdown

thedrow commented Jun 6, 2022

Thanks!

Celery definitely needs this one for its integration suite.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 6, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.52%. Comparing base (df0c28a) to head (ce52b43).
⚠️ Report is 440 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
+ Coverage   86.18%   86.52%   +0.34%     
==========================================
  Files          26       27       +1     
  Lines         702      720      +18     
  Branches       65       65              
==========================================
+ Hits          605      623      +18     
  Misses         76       76              
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tillahoffmann
Copy link
Copy Markdown
Contributor

The failing tests seem to be the consequence of a recent sphinx change (sphinx-doc/sphinx#10474). You should be able to fix it by changing language = None to language = 'en' in docs/conf.py.

@nshine
Copy link
Copy Markdown
Contributor Author

nshine commented Jun 6, 2022

Fixed

Copy link
Copy Markdown
Contributor

@tillahoffmann tillahoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few small comments.

Comment thread setup.py Outdated
Comment thread testcontainers/arangodb.py Outdated
Comment thread testcontainers/arangodb.py Outdated
Comment thread testcontainers/arangodb.py Outdated
Comment thread testcontainers/arangodb.py Outdated
Comment thread testcontainers/arangodb.py Outdated
@nshine nshine requested a review from tillahoffmann June 6, 2022 19:58
@nshine
Copy link
Copy Markdown
Contributor Author

nshine commented Jun 6, 2022

Thanks for your review. updated.

Copy link
Copy Markdown
Contributor

@tillahoffmann tillahoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more thoughts.

Comment thread testcontainers/arangodb.py Outdated
Comment thread testcontainers/arangodb.py
@nshine nshine requested a review from tillahoffmann June 7, 2022 05:34
@nshine
Copy link
Copy Markdown
Contributor Author

nshine commented Jun 8, 2022

Hi, all resolved.

@nshine
Copy link
Copy Markdown
Contributor Author

nshine commented Jun 10, 2022

@tillahoffmann - I will appreciate if you could merge and generate a new release.

@nshine
Copy link
Copy Markdown
Contributor Author

nshine commented Jun 14, 2022

Hi @thedrow / @SergeyPirogov any chance you can step in and approve&release this one ?

@SergeyPirogov SergeyPirogov merged commit c0dc701 into testcontainers:master Jun 14, 2022
@SergeyPirogov
Copy link
Copy Markdown
Contributor

@nshine thank you

@nshine
Copy link
Copy Markdown
Contributor Author

nshine commented Jun 14, 2022

Hi @SergeyPirogov
Thanks for the approve - can you please trigger a new release? i.e. 3.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants