Fixes #3998 and allows per test method screen recording#8617
Open
MartinAhrer wants to merge 5 commits into
Open
Fixes #3998 and allows per test method screen recording#8617MartinAhrer wants to merge 5 commits into
MartinAhrer wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is related to issue #3998.
BrowserWebDriverContainer is designed to execute each test in a fresh container.
However this is slow and not an option especially when test execution can't be parallelized.
Instead of recreating a fresh BrowserWebDriverContainer instance it may be sufficient to just re-create the VncRecorderContainer for each test.
This pull request offers a new method
reinitializeVncRecorderContainerthat tears down the vncRecordingContainer and creates a fresh instance. So it comes with out side effects of breaking existing functions.With that update it is fairly simple to create a subclass of
BrowserWebDriverContainerto take care of re-creating the vnc recorder by overriding theafterTestmethod.