Provide an API to force access to the host#4584
Merged
Merged
Conversation
Before this change, one of the biggest limitations of host port exposing was that the ports had to be exposed before the container starts. This change allows forcing starting the forwarding container, so that host listeners can be started/exposed after starting the consumer.
kiview
approved these changes
Oct 15, 2021
kiview
left a comment
kiview
left a comment
Member
There was a problem hiding this comment.
Super helpful improvement for the API 👍 . We need to update the docs accordingly.
Member
Author
|
@kiview added a mention to the docs 👍 |
rnorth
approved these changes
Oct 18, 2021
rnorth
left a comment
rnorth
left a comment
Member
There was a problem hiding this comment.
I think I'd suggest making the docs edit a bit more prominent, but this can be changed later and should not stand in the way of releasing this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, one of the biggest limitations of host port exposing
was that the ports had to be exposed before the container starts.
This change allows forcing starting the forwarding container,
so that host listeners can be started/exposed after starting the consumer.