Skip to content

Split Windows CI into core and non-core steps#4293

Merged
rnorth merged 1 commit into
masterfrom
split-windows-ci
Jul 20, 2021
Merged

Split Windows CI into core and non-core steps#4293
rnorth merged 1 commit into
masterfrom
split-windows-ci

Conversation

@rnorth

@rnorth rnorth commented Jul 20, 2021

Copy link
Copy Markdown
Member

No description provided.

@rnorth
rnorth requested review from bsideup and kiview as code owners July 20, 2021 07:41
@rnorth

rnorth commented Jul 20, 2021

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@kiview kiview left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have a high overlap between the stages, would it make sense to extract them into a template?

Maybe we can think about it, if we would get a fourth task with duplicate elements.

@bsideup

bsideup commented Jul 20, 2021

Copy link
Copy Markdown
Member

@kiview I would rather spend time on GHA hosted workers migration then :)

@rnorth
rnorth merged commit 3b3d130 into master Jul 20, 2021
@rnorth
rnorth deleted the split-windows-ci branch July 20, 2021 12:54
Comment thread azure-pipelines.yml
gradleWrapperFile: 'gradlew'
jdkVersionOption: '1.11'
options: '--no-daemon --continue'
tasks: 'clean check -x testcontainers:test'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is testcontainers:test intentional? I would've expected testcontainers:check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants