Move away from using quay.io for default images#2805
Merged
Conversation
rnorth
commented
May 28, 2020
bsideup
reviewed
May 28, 2020
|
|
||
| public String getRyukImage() { | ||
| return (String) properties.getOrDefault("ryuk.container.image", "quay.io/testcontainers/ryuk:0.2.3"); | ||
| return (String) properties.getOrDefault("ryuk.container.image", "testcontainersofficial/ryuk:latest"); |
Member
There was a problem hiding this comment.
Suggested change
| return (String) properties.getOrDefault("ryuk.container.image", "testcontainersofficial/ryuk:latest"); | |
| return (String) properties.getOrDefault("ryuk.container.image", "testcontainersofficial/ryuk:0.3.0"); |
Member
Author
There was a problem hiding this comment.
Yep, now that it's published 😆
bsideup
reviewed
May 28, 2020
| ## Customizing Ryuk resource reaper | ||
|
|
||
| > **ryuk.container.image = quay.io/testcontainers/ryuk:0.2.3** | ||
| > **ryuk.container.image = testcontainersoffical/ryuk:0.2.3** |
Member
There was a problem hiding this comment.
Suggested change
| > **ryuk.container.image = testcontainersoffical/ryuk:0.2.3** | |
| > **ryuk.container.image = testcontainersoffical/ryuk:0.3.0** |
Closed
slovdahl
reviewed
May 28, 2020
| > Used by Testcontainers' core | ||
|
|
||
| > **vncrecorder.container.image = quay.io/testcontainers/vnc-recorder:1.1.0** | ||
| > **vncrecorder.container.image = testcontainersoffical/vnc-recorder:1.1.0** |
Contributor
There was a problem hiding this comment.
Should it be testcontainersofficial?
| ## Customizing Ryuk resource reaper | ||
|
|
||
| > **ryuk.container.image = quay.io/testcontainers/ryuk:0.2.3** | ||
| > **ryuk.container.image = testcontainersoffical/ryuk:0.2.3** |
perlun
approved these changes
May 28, 2020
rnorth
marked this pull request as ready for review
May 28, 2020 20:38
bsideup
approved these changes
May 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.