Skip to content

Use relative path for temp dirs in test#2604

Merged
rnorth merged 2 commits into
masterfrom
fix-windows-authpull-test-failure
Apr 23, 2020
Merged

Use relative path for temp dirs in test#2604
rnorth merged 2 commits into
masterfrom
fix-windows-authpull-test-failure

Conversation

@rnorth

@rnorth rnorth commented Apr 22, 2020

Copy link
Copy Markdown
Member

For reasons I don't fully understand, DockerComposeContainer is failing to mount a directory when passed the absolute path form of temporary files created in AuthenticatedImagePullTest.

This only seems to happen on our Windows CI box, and I cannot reproduce locally on a Windows machine.

Converting the temp file path to relative form fixes the CI failure.

We should work out how this issue was occurring as it seems like there's a small bug lurking somewhere. But as this is the first known occurrence, I think it's safe to assume it's a pretty rare problem.

@rnorth
rnorth requested review from bsideup and kiview as code owners April 22, 2020 20:34
@rnorth

rnorth commented Apr 22, 2020

Copy link
Copy Markdown
Member Author

/azp run Windows 10 - Docker for Windows

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@rnorth

rnorth commented Apr 23, 2020

Copy link
Copy Markdown
Member Author

Raised #2606 so we don’t forget to track down the root cause.

@bsideup bsideup added this to the next milestone Apr 23, 2020
@rnorth

rnorth commented Apr 23, 2020

Copy link
Copy Markdown
Member Author

/azp run Windows 10 - Docker for Windows

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@rnorth
rnorth force-pushed the fix-windows-authpull-test-failure branch from 04bfb00 to d081dbd Compare April 23, 2020 12:12
@rnorth
rnorth merged commit 1e803b8 into master Apr 23, 2020
@rnorth
rnorth deleted the fix-windows-authpull-test-failure branch April 23, 2020 12:45
quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants