[r1.15-CherryPick]:Disallow comparing ObjectIdentityWrapper to others#32526
Merged
Conversation
mihaimaruseac
previously approved these changes
Sep 14, 2019
goldiegadde
changed the title
When using the experimental_ref() API in Tensors & Variables. A common bug I hit was incorrectly comparing a wrapped object with an unwrapped object instead of first calling deref(). To avoid this we raise an exception now instead of returning False. This implies that if Tensors and Variables are kept in the same set or dictionary as other objects, an exception can be raised if there is a hash collision. PiperOrigin-RevId: 268837575 (cherry picked from commit 57e8769)
goldiegadde
approved these changes
Sep 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the experimental_ref() API in Tensors & Variables. A common
bug I hit was incorrectly comparing a wrapped object with an unwrapped
object instead of first calling deref(). To avoid this we raise an
exception now instead of returning False. This implies that if Tensors
and Variables are kept in the same set or dictionary as other objects,
an exception can be raised if there is a hash collision.
PiperOrigin-RevId: 268837575
(cherry picked from commit 57e8769)