Fix regression in XLA in TensorFlow 1.13 RC0, RC1#25769
Merged
Conversation
… NHWC. The logic for the conversion has this assumption. This CL makes sure that this assumption holds, and adds tests for NCHW format. PiperOrigin-RevId: 225534508
copybara-service Bot
pushed a commit
that referenced
this pull request
Apr 30, 2025
…node workaround Imported from GitHub PR openxla/xla#25769 CUDA release r570/CUDA 12.8 has fixed the bug that cuda will hang when cuda-graph's conditional node has an empty body graph. Remove the workaround in XLA, tests have been covered by GpuCommandBufferTest.ConditionalCaseEmptyGraph Copybara import of the project: -- 355457198b24b1053ec79eacea13176e0751a5f8 by Shawn Wang <[email protected]>: remove cuda graph emtpy node inside conditional node workaround Merging this change closes #25769 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25769 from shawnwang18:shawnw/remove_empty_graph_workaround 355457198b24b1053ec79eacea13176e0751a5f8 PiperOrigin-RevId: 752342132
copybara-service Bot
pushed a commit
that referenced
this pull request
Apr 30, 2025
…node workaround Imported from GitHub PR openxla/xla#25769 CUDA release r570/CUDA 12.8 has fixed the bug that cuda will hang when cuda-graph's conditional node has an empty body graph. Remove the workaround in XLA, tests have been covered by GpuCommandBufferTest.ConditionalCaseEmptyGraph Copybara import of the project: -- 355457198b24b1053ec79eacea13176e0751a5f8 by Shawn Wang <[email protected]>: remove cuda graph emtpy node inside conditional node workaround Merging this change closes #25769 PiperOrigin-RevId: 753069210
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only convert BackpropFilterConv to depthwise convolution if format is… … NHWC.
The logic for the conversion has this assumption. This CL makes sure that this
assumption holds, and adds tests for NCHW format.
Fixes #25734
PiperOrigin-RevId: 225534508