Skip to content

Dispose #3

Closed
Closed

Description

@Muldec

Hi !

Quick question : I can't find when the dispose method of the MovieBloc is called. Am I missing something or is it dead code as of today ?

Activity

  1. lepinay commented on Oct 8, 2018

    @lepinay

    Implementation is bogus
    It should use an StateFullWidget instead of an InheritedWidget for the MovieProvider and implement dispose there

    See example here: https://stackoverflow.com/questions/51690230/flutter-inheritedwidget-dispose
    or here https://www.didierboelens.com/2018/08/reactive-programming---streams---bloc/#there-is-only-1-constraint-accessibility-of-the-bloc

  2. Muldec commented on Oct 10, 2018

    @Muldec
    Author

    Thanks ! I figured it out since my original question bbut its good to have a confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions