Skip to content

Add OTel tracing for standalone activities#1471

Merged
cconstable merged 4 commits into
mainfrom
cc/standalone-activity-tracing
Apr 22, 2026
Merged

Add OTel tracing for standalone activities#1471
cconstable merged 4 commits into
mainfrom
cc/standalone-activity-tracing

Conversation

@cconstable
Copy link
Copy Markdown
Contributor

@cconstable cconstable commented Apr 22, 2026 •
edited
Loading

What was changed

  • Implemented OTel interceptor methods for client standalone activities:
    • start_activity
    • cancel_activity
    • terminate_activity
    • describe_activity
    • count_activities
  • DID NOT implement Otel interceptor methods for:
    • list_activities: returns a lazy iterator.
  • Updated outdated testing info in README.

Why?

  • Standalone activities now produce tracing telemetry.

Checklist

  • New tests were added. poe test successful
  • Discuss list_activities. How should this be covered?

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 22, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cconstable cconstable marked this pull request as ready for review April 22, 2026 16:09
@cconstable cconstable requested a review from a team as a code owner April 22, 2026 16:09
cconstable
cconstable commented Apr 22, 2026
View reviewed changes
Comment thread tests/contrib/opentelemetry/test_opentelemetry.py
# * signal failure and wft failure from signal


async def test_opentelemetry_standalone_activity_tracing(
Copy link
Copy Markdown
Contributor Author

@cconstable cconstable Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar testing best practices in python so the tests were mostly LLM-generated and need a look over. They seem reasonable to me but would love another pair of eyes on them.

@cconstable cconstable merged commit 5ff4e35 into main Apr 22, 2026
30 of 31 checks passed
@cconstable cconstable deleted the cc/standalone-activity-tracing branch April 22, 2026 19:13
@cconstable cconstable mentioned this pull request Apr 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tconley1428 tconley1428 tconley1428 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cconstable @CLAassistant @tconley1428