Fix flaky OpenAI test timeouts#1466
Merged
Merged
Conversation
test_hello_world_agent[False] had a 5s execution timeout and test_input_guardrail[False] had a 10s timeout, but both use a 30s activity start_to_close_timeout. The workflow times out before the OpenAI API call can complete on slower CI runners. Bump both to 60s.
brianstrauch
approved these changes
Apr 20, 2026
Member
brianstrauch
left a comment
brianstrauch
left a comment
There was a problem hiding this comment.
+1 but in the long run these tests should be rewritten to not make external API calls
Contributor
Author
|
These tests maybe shouldn't but e2e smoke/system tests with real API calls are good and should live somewhere... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while working on #1448. Encountered repeated failures on 3.14/ubuntu-latest with the tests in question here and then no failures of these tests after these changes.
Summary
test_hello_world_agent[False]had a 5sexecution_timeoutandtest_input_guardrail[False]had 10s, but both use a 30s activitystart_to_close_timeoutubuntu-latest)Test plan
build-lint-test (3.14, ubuntu-latest)OpenAI test step passes