Skip to content

Implement is_running() for asyncio loop#1463

Merged
brianstrauch merged 1 commit into
mainfrom
is-running-override
Apr 17, 2026
Merged

Implement is_running() for asyncio loop#1463
brianstrauch merged 1 commit into
mainfrom
is-running-override

Conversation

@brianstrauch
Copy link
Copy Markdown
Member

  • Implements is_running() on the Workflow asyncio loop, returning True, so asyncio.get_running_loop().is_running() works inside Workflows instead of raising NotImplementedError.
  • This is needed for the LangGraph plugin, because the langgraph package raises this error when run in a Temporal Workflow.

Test plan

  • New test_workflow_loop_is_running asserts the loop reports running from inside a Workflow
  • Existing Workflow test suite passes
  • LangGraph plugin test suite passes

@brianstrauch brianstrauch requested a review from a team as a code owner April 17, 2026 22:10
@brianstrauch brianstrauch merged commit e75147e into main Apr 17, 2026
17 checks passed
@brianstrauch brianstrauch deleted the is-running-override branch April 17, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants