Consume and Update to Latest Protos - #92
Merged
Merged
Conversation
shawnhathaway
commented
May 21, 2020
| getDecision(new DecisionId(DecisionTarget.ACTIVITY, scheduledEventId)); | ||
| decision.handleCancellationFailureEvent(event); | ||
| return decision.isDone(); | ||
| // RequestCancelActivityTaskFailedEventAttributes attributes = |
Contributor
Author
There was a problem hiding this comment.
Looks like RequestCancelActivityTaskFailed is deprecated, but event type still exists.
shawnhathaway
marked this pull request as ready for review
May 22, 2020 18:45
mfateev
approved these changes
May 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to latest protos (v0.23.1).
Mostly renames, but meaningful changes around ActivityCancellation and replacing
activityIdwithscheduledEventId.