Skip to content

use datetime.strptime instead of parser - #38

Merged
blakesmith merged 4 commits into
tempodb:masterfrom
joshowen:master
Apr 8, 2014
Merged

blakesmith merged 4 commits into
tempodb:masterfrom
joshowen:master

Conversation

@joshowen

Copy link
Copy Markdown
Contributor

its much faster and we're always parsing ISO 8601 format

Josh Owen added 4 commits February 25, 2014 20:26
its much faster and we're always parsing ISO 8601 format
To handle ISO 8601
this isn't a great test change, but zulu is implied in 8601
@joshowen

Copy link
Copy Markdown
Contributor Author

We've been using this in our environment and seen a large performance improvement. It would be nice to get this into the main distribution.

@blakesmith

Copy link
Copy Markdown
Contributor

Hey Josh,

Thanks for sending this in. As far as I can tell, there doesn't seem to be any downsides to this change. Can you think of any? If not, this can probably be merged straight away.

Blake

@joshowen

Copy link
Copy Markdown
Contributor Author

None that I can think of

blakesmith added a commit that referenced this pull request Apr 8, 2014
use datetime.strptime instead of parser
@blakesmith
blakesmith merged commit a9f09fb into tempodb:master Apr 8, 2014
@blakesmith

Copy link
Copy Markdown
Contributor

Thanks for this @joshowen - We're slow on the update because we're working on a major rev of the client that should improve performance and usability. We'll make sure this performance improvement you submitted gets ported to the new structure.

Thanks again for your patience!

Blake

@joshowen

joshowen commented Apr 8, 2014

Copy link
Copy Markdown
Contributor Author

I think the slowness is coming from the backend on some of our large
queries.

What is the optimal number of datapoints or streams to request at a time?


Tell your friends about Openfolio. Share on
Twitterhttps://twitter.com/share?url=https%3A%2F%2Fopenfolio.com&text=Check%20out%20%40openfolioapp%2C%20they%27re%20changing%20investing%20with%20the%20wisdom%20and%20financial%20decisions%20of%20your%20network.%20Sign%20up&amp
, Facebookhttps://www.facebook.com/sharer/sharer.php?u=https%3A%2F%2Fopenfolio.com,
and LinkedInhttps://www.linkedin.com/cws/share?url=https%3A%2F%2Fopenfolio.com
.

Follow us on Twittehttps://twitter.com/intent/user?screen_name=openfolioapp
r https://twitter.com/intent/user?screen_name=openfolioapp and Like us on
Facebook https://www.facebook.com/Openfolio.

On Tue, Apr 8, 2014 at 3:52 PM, Blake Smith [email protected]:

Thanks for this @joshowen https://github.com/joshowen - We're slow on
the update because we're working on a major rev of the client that should
improve performance and usability. We'll make sure this performance
improvement you submitted gets ported to the new structure.

Thanks again for your patience!

Blake

Reply to this email directly or view it on GitHubhttps://github.com//pull/38#issuecomment-39893719
.

@blakesmith

Copy link
Copy Markdown
Contributor

Here are some of the guidelines we recommend for our multi-write interface

If you're looking for something more specific to your situation, can you email [email protected] and cc me on it? ([email protected])

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants