🔧 Forge: NuGet Dependency and Framework Modernization#1
Conversation
* Added `net8.0` and `net9.0` to `TargetFrameworks` in all projects * Updated dependencies to the latest stable versions * Used conditional compilation for `ArgumentOutOfRangeException.ThrowIfLessThan` and `ArgumentNullException.ThrowIfNull` on NET8+ targets * Fixed nullability warnings in tests and legacy benchmarks * Created `.jules/forge.md` for modernization logging Co-authored-by: tedd <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Modernizes the Tedd.ObjectPool solution by multi-targeting newer .NET TFMs, updating test/benchmark dependencies, and tightening argument/nullability validation while preserving netstandard2.0 compatibility.
Changes:
- Multi-targeted the main library to
netstandard2.0;net8.0;net9.0and updated tests/benchmarks to includenet9.0. - Added conditional argument validation using .NET 8+ throw helpers in hot-path APIs.
- Addressed nullability warnings in tests and legacy benchmark code.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Tedd.ObjectPool/Tedd.ObjectPool.csproj | Multi-targets the library for netstandard2.0 + modern .NET TFMs. |
| src/Tedd.ObjectPool/ObjectPool.cs | Uses .NET 8+ throw helpers via conditional compilation; minor validation refactor. |
| src/Tedd.ObjectPool.Tests/Tedd.ObjectPool.Tests.csproj | Multi-targets tests; upgrades xUnit/test tooling packages. |
| src/Tedd.ObjectPool.Tests/ObjectPoolTests.cs | Adjusts tests for strict nullability (DummyObject?[] + null-forgiving). |
| src/Tedd.ObjectPool.Benchmarks/Tedd.ObjectPool.Benchmarks.csproj | Multi-targets benchmarks; upgrades BenchmarkDotNet and dependencies. |
| src/Tedd.ObjectPool.Benchmarks/Legacy/ObjectPool1.cs | Updates nullability annotations in legacy benchmark implementation. |
| .jules/forge.md | Adds Forge tracking notes (currently with formatting issue). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Tedd.ObjectPooltarget frameworks, tests dependencies, benchmark dependencies, package metadata, nullability validation.net8.0andnet9.0explicit targets, upgraded testing tools (xunit, coverlet) and benchmarking tools (BenchmarkDotNet) to latest. Implemented conditional compilation#if NET8_0_OR_GREATERin hot paths. Fixed strict nullability (#nullable enable).netstandard2.0. Explicitly addednet8.0andnet9.0. Total backward source and binary compatibility for legacy consumers intact.dotnet build,dotnet test -f net8.0,dotnet pack -c Release,dotnet format --verify-no-changes.netstandard2.0,net8.0,net9.0) insideTedd.ObjectPool.2.0.0.nupkgunderlib/.PR created automatically by Jules for task 6249327607548631180 started by @tedd