Fixed issue with sdk attribute returns None in nested models. - #4
Merged
Merged
Conversation
Member
|
Nice catch, I'm merging it and pushing it to a new version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever models that use get / list endpoints, its child resume models'
sdkattribute returns None. It causes functions likeget_full_setandget_full_cardto raise AttributeError.This pull request includes a change to the
_from_dictmethod in thesrc/tcgdexsdk/utils.pyfile. The change ensures that thesdkattribute is properly set for all child models within the main model.src/tcgdexsdk/utils.py: Modified the_from_dictmethod to recursively set thesdkattribute for child models and lists of models.