updateAzureContainernameRule : lift contianer name length restriction#140
updateAzureContainernameRule : lift contianer name length restriction#140plutoshe wants to merge 3 commits into
Conversation
|
Can you please provide a reason for this change? |
|
It seems that azure go SDK lift the restriction of container name. |
|
The old restriction of container name is that the length must be 32. |
|
@plutoshe Can you link the related change in the commit message or comment on github? |
There was a problem hiding this comment.
you can combine 57-60 to one line return err (just for your information)
There was a problem hiding this comment.
Yeah, it seems redundant.
Thanks for comments.
|
I found this problem by accessing azure storage yesterday. |
Your change is based on an uncertain assumption. If you can provide more information, the reviewer can have a better context of the change. For example, you might share me which commit in azure go sdk changes the restriction (https://github.com/Azure/azure-sdk-for-go). Or how do you know the restriction changed. |
We want to make sure this time we can get it right. So we want to be more careful. It would be helpful if you can find any related doc in go sdk. |
|
Sure. |
|
@plutoshe Sure. Thanks! |
|
Azure Naming Rules |
We can start with the simplest ones: length. I am OK with adding a few TODOs. |
|
Sure, I will list some TODOs, and do the length inspection first. |
|
@plutoshe Great. Thanks for finding the doc and putting the effort. |
b4cd816 to
90b082e
Compare
|
why this break the test? |
No description provided.