Skip to content

Move topo out of 'example' directory#136

Open
5kg wants to merge 1 commit into
taskgraph:masterfrom
5kg:re_org
Open

Move topo out of 'example' directory#136
5kg wants to merge 1 commit into
taskgraph:masterfrom
5kg:re_org

Conversation

@5kg
Copy link
Copy Markdown
Contributor

@5kg 5kg commented May 26, 2015

Hi,

This is a RFC pull request to change the project directory layout, which I think is cleaner than before.

Comments are welcome.

Thanks!
Zifei

@xiaoyunwu
Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@plutoshe
Copy link
Copy Markdown
Contributor

LGTM

@hongchaodeng
Copy link
Copy Markdown

Hi Zifei,

  • The ".script" is a way to hide from search tool like "ag"
  • All applications will be moved out of this repo in the end
  • The "interface" should be changed to something like "api/v$(version)" because of go's weird dependency management. I don't think we have any version plan yet.

@xiang90
Copy link
Copy Markdown

xiang90 commented May 26, 2015

well... it is more common to put the interface together with its implementation when possible (for example, our framework)

I found it's odd for applications of taskgraph (e.g. bwmf) to import
'github.com/taskgraph/taskgraph/example/topo'.
@5kg 5kg changed the title [RFC] Change project directory layouts Move topo out of 'example' directory Jun 2, 2015
@5kg
Copy link
Copy Markdown
Contributor Author

5kg commented Jun 2, 2015

bwmf has been moved to a separated repo.

And I agree the versioned API idea.

Now I am wondering if example/topo should be moved to a better place.

@hongchaodeng
Copy link
Copy Markdown

We are in the middle of defining reliable message that involves possible
change on topology.

We can make a decision then once the docs and definition are finalized.

On Mon, Jun 1, 2015 at 11:15 PM, Zifei Tong [email protected]
wrote:

bwmf has been moved to a separated repo.

And I agree the versioned API idea.

Now I am wondering if example/topo should be moved to a better place.


Reply to this email directly or view it on GitHub
#136 (comment).

- Hongchao Deng
Software Engineer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants