Skip to content

bump test-run version - #188

Merged
Totktonada merged 1 commit into
masterfrom
bump-test-run-version
Feb 10, 2021
Merged

bump test-run version#188
Totktonada merged 1 commit into
masterfrom
bump-test-run-version

Conversation

@ligurio

@ligurio ligurio commented Feb 8, 2021

Copy link
Copy Markdown
Member

commit 4aaadb9 ('Fix luacheck
warnings') fixes luacheck warnings in Lua source code. Bumping version
allows to remove test-run directory from exclusions in .luacheckrc in
tarantool repository.

@ligurio
bump test-run version
2a3a172 
commit 4aaadb9 ('Fix luacheck
warnings') fixes luacheck warnings in Lua source code. Bumping version
allows to remove test-run directory from exclusions in .luacheckrc in
tarantool repository.
@Totktonada

Totktonada commented Feb 10, 2021

Copy link
Copy Markdown
Contributor

I'll bring a few context details:

  1. There are tests in the unit directory, which is run by python setup.py test and in CI.
  2. There are tests in the test directory (added within PR Implement reconnection strategy class #109), which is run by cd test && ./test-run.py and is not run under CI (Run all tests under CI #111). There is only one test here: cluster-py/multi.test.py.

I had the idea to verify the test-run update and ensure that tests under test-run are working with the new test-run version. However they do not work neither before commit, nor after.

On the current master:

[001] Test.run() received the following error:
[001] Traceback (most recent call last):
[001]   File "/home/alex/projects/tarantool-meta/tarantool-python/test-run/lib/test.py", line 180, in run
[001]     self.execute(server)
[001]   File "/home/alex/projects/tarantool-meta/tarantool-python/test-run/lib/tarantool_server.py", line 166, in execute
[001]     **server.__dict__))
[001]   File "cluster-py/multi.test.py", line 7, in <module>
[001]     from mesh_connection import MeshConnection
[001]   File "../tarantool/mesh_connection.py", line 11, in <module>
[001]     from tarantool.error import (
[001] ImportError: cannot import name ConfigurationError

[001] [ fail ]
[001] Test failed! Output from reject file multi.reject:
[001]

On the most recent test-run (72f8b89332b552cf20b2143e6dae7fe5042a9f79):

[001] Test.run() received the following error:
[001] Traceback (most recent call last):
[001]   File "/home/alex/projects/tarantool-meta/tarantool-python/test-run/lib/test.py", line 182, in run
[001]     self.execute(server)
[001]   File "/home/alex/projects/tarantool-meta/tarantool-python/test-run/lib/tarantool_server.py", line 400, in execute
[001]     **server.__dict__))
[001]   File "cluster-py/multi.test.py", line 58, in <module>
[001]     encoding=ENCODING_DEFAULT)
[001]   File "../tarantool/mesh_connection.py", line 214, in __init__
[001]     raise ConfigurationError(msg)
[001] ConfigurationError: Address {'host': None, 'port': '/home/alex/projects/tarantool-meta/tarantool-python/test/var/001_cluster-py/instance/0/instance1.sock'}: host value must be string type, port value must be int type
[001] 
[001] [ fail ]
[001] Test failed! Output from reject file var/rejects/cluster-py/multi.reject:
[001] box.schema.user.grant('guest', 'read,write,execute', 'universe')
[001] ---
[001] ...
[001] _ = box.schema.space.create('test')
[001] ---
[001] ...
[001] _ = box.space.test:create_index('primary')
[001] ---
[001] ...
[001] box.schema.user.grant('guest', 'read,write,execute', 'universe')
[001] ---
[001] ...
[001] _ = box.schema.space.create('test')
[001] ---
[001] ...
[001] _ = box.space.test:create_index('primary')
[001] ---
[001] ...

So, it is broken and will not become more broken. I don't mind updating.

@Totktonada
Totktonada merged commit 30b3775 into master Feb 10, 2021
@Totktonada
Totktonada deleted the bump-test-run-version branch February 10, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Totktonada Totktonada Totktonada approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

2 participants

@ligurio @Totktonada