Removes manual query param generation#686
Merged
Merged
Conversation
t8y8
suggested changes
Sep 29, 2020
t8y8
approved these changes
Oct 19, 2020
vchavatapalli
pushed a commit
to vchavatapalli/server-client-python
that referenced
this pull request
May 5, 2026
* Removes manual query param generation * Fixes v3.5 test issue by using regex matching * Moving all query param verifications to use regex search * Adds back removed method with deprecation warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing manual query param generation in req_options, and delegating that step to the requests library.
By doing this, the requests library will encode the url for us, fixing #418, #516, #578.
Some endpoints have their own query params added, like workbook publish overwrite flag. The requests library will append new query params to the existing one in this case.