This repository was archived by the owner on Jul 10, 2019. It is now read-only.
[checker] Checker bin, JSON config file, new Check interface#121
Open
kawmarco wants to merge 6 commits intosystemboot:masterfrom
Open
[checker] Checker bin, JSON config file, new Check interface#121kawmarco wants to merge 6 commits intosystemboot:masterfrom
kawmarco wants to merge 6 commits intosystemboot:masterfrom
Conversation
Collaborator
|
hey @kawmarco , thanks for the contribution! Could you please re-submit with DCO (just amend the commit with |
kawmarco
force-pushed
the
checker
branch
6 times, most recently
from
0cea717 to
cd6541a
Compare
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 50.17% 46.99% -3.19%
==========================================
Files 14 21 +7
Lines 562 798 +236
==========================================
+ Hits 282 375 +93
- Misses 252 391 +139
- Partials 28 32 +4
Continue to review full report at Codecov.
|
kawmarco
force-pushed
the
checker
branch
4 times, most recently
from
3d2ca90 to
34d9ed4
Compare
kawmarco
changed the title
insomniacslk
suggested changes
May 24, 2019
Collaborator
insomniacslk
left a comment
insomniacslk
left a comment
There was a problem hiding this comment.
I've done only a partial review, publishing it to unblock you.
Also note - several files have changed permissions with this commit, they have now an executable bit set where they should not
kawmarco
pushed a commit
to kawmarco/systemboot
that referenced
this pull request
May 29, 2019
kawmarco
pushed a commit
to kawmarco/systemboot
that referenced
this pull request
May 29, 2019
kawmarco
pushed a commit
to kawmarco/systemboot
that referenced
this pull request
May 29, 2019
Signed-off-by: Marco Kawajiri <[email protected]>
kawmarco
pushed a commit
to kawmarco/systemboot
that referenced
this pull request
May 29, 2019
Signed-off-by: Marco Kawajiri <[email protected]>
added 6 commits
May 29, 2019 16:30
Signed-off-by: Marco Kawajiri <[email protected]>
Signed-off-by: Marco Kawajiri <[email protected]>
Signed-off-by: Marco Kawajiri <[email protected]>
Signed-off-by: Marco Kawajiri <[email protected]>
Signed-off-by: Marco Kawajiri <[email protected]>
Signed-off-by: Marco Kawajiri <[email protected]>
Collaborator
|
Discussed offline, we will reopen this one against uroot after the move is done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checker/main.go) which accepts a JSON configuration file as input (--config-file), containing a list ofChecksCheckstructs to be more friendly to JSON configuration and JSON report output, thinking of the following workflowCheckFun(CheckArgs)functions, which contain the actual logic of the check, and "register" their functions usingregisterCheckFunoninit()(so that they are registered in a global map and we can then find the check functions by name at runtime)Checkstruct defines howCheckFunsshould be called, includingCheckArgs, possible remediations and metadata. The config file is achecklist(a list ofCheck)Check.Run()returns a JSON-friendlyCheckResult, containing the result of theCheckand the result of the configured remediationsTODO:
pkg/checker/checker.go