Skip to content

Performance improvement on tabs replacement #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendo merged 1 commit into from
May 9, 2014
Merged

Performance improvement on tabs replacement #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/bitter/formats/symphony.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,19 @@ public function process($source) {
}

protected function processTabs() {
while (strstr($this->output, "\t")) {
$this->output = preg_replace_callback('%^([^\t]*)(\t+)%', array($this, 'processTabsLine'), $this->output);
// first split the output into manageable chunks
$lines = explode(PHP_EOL, $this->output);
$linesCount = count($lines);
// fix lines one by one
for ($x = 0; $x < $linesCount; $x++) {
// while there are still tabs
while (strpos($lines[$x], "\t") !== FALSE) {
// replace tabs for spaces
$lines[$x] = preg_replace_callback('%^([^\t]*)([\t]+)%', array($this, 'processTabsLine'), $lines[$x]);
}
}
// concat the final output
$this->output = implode(PHP_EOL, $lines);
}

protected function processTabsLine($matches) {
Expand Down