Conversation
…t/symengine into series-generic-changes UnivariateSeries now inherits from SeriesBase
…t/symengine into series-generic-changes
…t/symengine into series-generic-changes
…t/symengine into series-generic-changes
… series-generic-changes Wrong commit please ignore
…t/symengine into series-generic-changes update
|
Let me know if you need any help here or in gitter |
|
Right, for the convert functions what would be the outputs? Right now they return either SymEngine::Integer or SymEngine::Rational but there are no operator= that can perform the operation in series_visitor.h |
|
Output should be of Coefficient type, in your case int. Btw, you can have the Coefficient type as Expression instead of int. |
…_generic.cpp, implemented mul, pow, find_cf, root, diff
… series-generic-changes --merging
… univariateseries Update univariate series with current symengine master
… univariateseries
|
|
||
| void bvisit(const Pow &self) { | ||
| RCP<const Basic> _base = expand(self.get_base()); | ||
| if(is_a<const UnivariatePolynomial>(*self.get_base())) { |
There was a problem hiding this comment.
Can you take this functionality out of this function and call the function?
… in Expression, refactored UnivariateIntPolynomial from_dict and series_generic diff, conformed to style standards
…constructor issues
67cbfad to
118a009
Compare
|
Anyone know where this "std::bad_alloc" error is coming from? This is when I run test_series_generic. |
…ric, commented out map_uint_mpz univariate_series func
|
Now that #857 is merged, can you make a new pull request with the changes to |
|
Any particular reason? We already have this PR. |
|
This PR has too many commits that are now irrelevant. |
|
Edit: ok, will set up new one. |
8 participants
Started making changes with series-generic. Implemented skeleton methods/functions.