Conversation
jrioux
added a commit
to jrioux/csympy
that referenced
this pull request
Sep 19, 2013
Before this change:
```
$ ctest
Test project /home/jrioux/git/csympy
Start 1: test_rcp
1/6 Test symengine#1: test_rcp ......................... Passed 0.01 sec
Start 2: test_basic
2/6 Test symengine#2: test_basic ....................... Passed 0.02 sec
Start 3: test_arit
3/6 Test symengine#3: test_arit ........................***Exception: Other 0.48 sec
Start 4: test_poly
4/6 Test symengine#4: test_poly ........................ Passed 0.01 sec
Start 5: test_functions
5/6 Test symengine#5: test_functions ................... Passed 0.02 sec
Start 6: test_subs
6/6 Test symengine#6: test_subs ........................ Passed 0.01 sec
83% tests passed, 1 tests failed out of 6
Total Test time (real) = 0.58 sec
The following tests FAILED:
3 - test_arit (OTHER_FAULT)
Errors while running CTest
```
The log gave the failing test in test_arit:
```
3x^2 + 2x^3 + x^4 + 2x^5 + x^6
x^2 + 2x^3 + 3x^4 + 2x^5 + x^6
test_arit: /home/jrioux/git/csympy/src/tests/basic/test_arit.cpp:421: void test_expand2(): Assertion `eq(r1, r2)' failed.
```
Benchmarks gave:
```
$ for f in benchmarks/expand{1,2,2b,3}; do ./$f; done
Expanding: (y + z + w + x)^60
170ms
number of terms: 39711
Expanding: (y + z + w + x)^15*((y + z + w + x)^15 + w)
1743ms
number of terms: 6272
poly_mul start
poly_mul stop
135ms
number of terms: 6272
Expanding: (z^x + x^y + y^x)^100
44ms
number of terms: 5151
```
After this change:
```
$ ctest
Test project /home/jrioux/git/csympy
Start 1: test_rcp
1/6 Test symengine#1: test_rcp ......................... Passed 0.00 sec
Start 2: test_basic
2/6 Test symengine#2: test_basic ....................... Passed 0.01 sec
Start 3: test_arit
3/6 Test symengine#3: test_arit ........................ Passed 0.02 sec
Start 4: test_poly
4/6 Test symengine#4: test_poly ........................ Passed 0.01 sec
Start 5: test_functions
5/6 Test symengine#5: test_functions ................... Passed 0.00 sec
Start 6: test_subs
6/6 Test symengine#6: test_subs ........................ Passed 0.00 sec
100% tests passed, 0 tests failed out of 6
Total Test time (real) = 0.06 sec
```
Benchmarks give:
```
$ for f in benchmarks/expand{1,2,2b,3}; do ./$f; done
Expanding: (y + z + w + x)^60
169ms
number of terms: 39711
Expanding: (y + z + w + x)^15*((y + z + w + x)^15 + w)
1837ms
number of terms: 6272
poly_mul start
poly_mul stop
135ms
number of terms: 6272
Expanding: (z^x + x^y + y^x)^100
44ms
number of terms: 5151
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.