Skip to content

Gmp - #5

Merged
certik merged 34 commits into
masterfrom
gmp
Aug 8, 2013
Merged

Gmp#5
certik merged 34 commits into
masterfrom
gmp

Conversation

@certik

@certik certik commented Aug 8, 2013

Copy link
Copy Markdown
Contributor

No description provided.

certik added a commit that referenced this pull request Aug 8, 2013
@certik
certik merged commit e2835bd into master Aug 8, 2013
@certik
certik deleted the gmp branch August 8, 2013 00:24
jrioux added a commit to jrioux/csympy that referenced this pull request Sep 19, 2013
Before this change:

```
$ ctest
Test project /home/jrioux/git/csympy
    Start 1: test_rcp
1/6 Test symengine#1: test_rcp .........................   Passed    0.01 sec
    Start 2: test_basic
2/6 Test symengine#2: test_basic .......................   Passed    0.02 sec
    Start 3: test_arit
3/6 Test symengine#3: test_arit ........................***Exception: Other  0.48 sec
    Start 4: test_poly
4/6 Test symengine#4: test_poly ........................   Passed    0.01 sec
    Start 5: test_functions
5/6 Test symengine#5: test_functions ...................   Passed    0.02 sec
    Start 6: test_subs
6/6 Test symengine#6: test_subs ........................   Passed    0.01 sec

83% tests passed, 1 tests failed out of 6

Total Test time (real) =   0.58 sec

The following tests FAILED:
	  3 - test_arit (OTHER_FAULT)
Errors while running CTest
```

The log gave the failing test in test_arit:

```
3x^2 + 2x^3 + x^4 + 2x^5 + x^6
x^2 + 2x^3 + 3x^4 + 2x^5 + x^6
test_arit: /home/jrioux/git/csympy/src/tests/basic/test_arit.cpp:421: void test_expand2(): Assertion `eq(r1, r2)' failed.
```

Benchmarks gave:

```
$ for f in benchmarks/expand{1,2,2b,3}; do ./$f; done
Expanding: (y + z + w + x)^60
170ms
number of terms: 39711
Expanding: (y + z + w + x)^15*((y + z + w + x)^15 + w)
1743ms
number of terms: 6272
poly_mul start
poly_mul stop
135ms
number of terms: 6272
Expanding: (z^x + x^y + y^x)^100
44ms
number of terms: 5151
```

After this change:

```
$ ctest
Test project /home/jrioux/git/csympy
    Start 1: test_rcp
1/6 Test symengine#1: test_rcp .........................   Passed    0.00 sec
    Start 2: test_basic
2/6 Test symengine#2: test_basic .......................   Passed    0.01 sec
    Start 3: test_arit
3/6 Test symengine#3: test_arit ........................   Passed    0.02 sec
    Start 4: test_poly
4/6 Test symengine#4: test_poly ........................   Passed    0.01 sec
    Start 5: test_functions
5/6 Test symengine#5: test_functions ...................   Passed    0.00 sec
    Start 6: test_subs
6/6 Test symengine#6: test_subs ........................   Passed    0.00 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) =   0.06 sec
```

Benchmarks give:

```
$ for f in benchmarks/expand{1,2,2b,3}; do ./$f; done
Expanding: (y + z + w + x)^60
169ms
number of terms: 39711
Expanding: (y + z + w + x)^15*((y + z + w + x)^15 + w)
1837ms
number of terms: 6272
poly_mul start
poly_mul stop
135ms
number of terms: 6272
Expanding: (z^x + x^y + y^x)^100
44ms
number of terms: 5151
```
isuruf pushed a commit that referenced this pull request Mar 13, 2016
Rewrite Polynomial printing to make it simpler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant