Refine benchmark suite#203
Merged
kateinoigakukun merged 3 commits intomainfrom Aug 12, 2022
Merged
Conversation
|
Time Change: +5,243ms (24%) 🚨 Total Time: 20,996ms
View Unchanged
|
MaxDesiatov
approved these changes
Aug 12, 2022
Member
MaxDesiatov
left a comment
MaxDesiatov
left a comment
There was a problem hiding this comment.
These are great improvements, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had been running benchmarks for a long time and they were very unstable. And also couldn't find meaningful results.
I changed to perform benchmarks with release configuration, and don't repeat noisy prelude for each benchmark.
Also added several benchmark cases to find our bridging bottlenecks (assignment, call, value conversion, ...)