Skip to content

Upgrade to newer Ruby, ActiveRecord, RSpec#294

Merged
swanson merged 9 commits intostringer-rss:masterfrom
dwaite:master
Dec 31, 2013
Merged

Upgrade to newer Ruby, ActiveRecord, RSpec#294
swanson merged 9 commits intostringer-rss:masterfrom
dwaite:master

Conversation

@dwaite
Copy link
Copy Markdown
Contributor

@dwaite dwaite commented Dec 27, 2013

Ruby 2.1.0p0, ActiveRecord 4, Rspec 2.14.1, and mainline versions of feedzirra, feedbag, and sinatra-contrib.

@swanson
Copy link
Copy Markdown
Collaborator

swanson commented Dec 27, 2013

This looks great - I'll try to make some time in the next few days to play around and make sure everything is working. Glad to be able to get back on mainline for those gems - good to see the forks have been merged and patches applied :)

Could you add the new ruby to the travis build matrix in _travis.yml? I'm not sure I want to bump the required version but it would be good to support 2.1

@duenni
Copy link
Copy Markdown

duenni commented Dec 28, 2013

I don't think Ruby 2.1 is suported on Openshift. Will I still be able to use stringer on Openshift if this gets merged? Thanks in advance.

@swanson swanson merged commit 0b2abe8 into stringer-rss:master Dec 31, 2013
@swanson
Copy link
Copy Markdown
Collaborator

swanson commented Dec 31, 2013

I went with 2.0.0 in the Gemfile and setup 2.1.0 to run on Travis.

Thanks!

@jasonngpt
Copy link
Copy Markdown
Contributor

@duenni i just tried deploying it on a test instance in OpenShift with the latest stringer here. The instructions in docs/OpenShift.md are still valid, except for 1 issue. The gem 'pry-byebug' depends on 'byebug' which needs Ruby 2.0 at least.

So there are 2 options so far:

  1. Remove the Development and Test env entries in the Gemfile since we only need Production env for OpenShift.
  2. Changed the 'pry-byebug' back to 'pry-debugger' in the Gemfile

I tried both and the deployment to OpenShift works, with Stringer loading properly. Fetching feeds works too. Note that this is purely for production deployment to OpenShift and does not take into account the test and dev env.

Not sure if this is the correct way, but if it is okay, I will update the docs/OpenShift.md docs.

@swanson
Copy link
Copy Markdown
Collaborator

swanson commented Jan 2, 2014

I'm not even sure what pry-byebug even does. @dwaite is this needed?

@dwaite
Copy link
Copy Markdown
Contributor Author

dwaite commented Jan 3, 2014

AFAIK, byebug is the replacement for debugger in 2.0 and beyond. hence the switch from pry-debugger to pry-byebug. I'll see about platform-specific declarations.

@swanson
Copy link
Copy Markdown
Collaborator

swanson commented Jan 3, 2014

I have not used OpenShift so maybe this is a silly question but - can you configure it to just install the production environment from the Gemfile? Basically bundle install --without development test?

@jasonngpt
Copy link
Copy Markdown
Contributor

I managed to get stringer working on OpenShift by doing the bundle install --without development test @swanson mentioned (by adding a pre_build action_hook) in a fresh installation. so this should be do-able.

I think I will test it out on an upgrade and see if it works, then I will update the OpenShift.md docs which should conclude this issue on OpenShift hopefully.

@jasonngpt
Copy link
Copy Markdown
Contributor

Ran into another issue. Seems like there are some conflicts between OpenShift's activemodel and the new activemodel 4. Guess I will ask in the OpenShift forums first.

@duenni
Copy link
Copy Markdown

duenni commented Jan 5, 2014

Thanks for looking into this, really appreciated!

@jasonngpt
Copy link
Copy Markdown
Contributor

Seems like it is a bug in OpenShift when I added the bundle install --without development test into the pre_build script will result in an error. I filed a bug in the OpenShift bug system.

Meanwhile, the 2 methods I mentioned above still works. (Removing dev and test environment, or changing pry-byebug to pry-debugger) I just tested them. So this might be the easiest way out. I will update the OpenShift.md if there are no objections?

@swanson
Copy link
Copy Markdown
Collaborator

swanson commented Jan 7, 2014

Yes please - go ahead and update the docs. Can always change them later if it gets resolved :)

@jasonngpt
Copy link
Copy Markdown
Contributor

updated :) opted for the easier way out. but wondering if it might confuse people.. maybe i should add a note indicating that it is for OpenShift production only?

@mfojtik
Copy link
Copy Markdown

mfojtik commented Jan 8, 2014

@jasonngpt @swanson the issue in OpenShift is currently being addressed in this PR: openshift/origin-server#4426
Any feedback on this PR or suggestion how to handle this batter are welcome :-) It should be resolved in the next OpenShift Online release.

@jasonngpt
Copy link
Copy Markdown
Contributor

thanks @mfojtik! i didn't know OpenShift is on GitHub :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants