Skip to content

Add option to use title/description as class name part - #20

Merged
vearutop merged 1 commit into
masterfrom
names-from-descriptions
Sep 12, 2019
Merged

vearutop merged 1 commit into
masterfrom
names-from-descriptions

Conversation

@vearutop

Copy link
Copy Markdown
Member

This PR adds an option to use schema description/title in generated class name instead of transitive keyword (oneOf, not, etc...) so that HTTPSecuritySchemeOneOf0 could become HTTPSecuritySchemeBearer.

@codecov

codecov Bot commented Sep 12, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #20 into master will increase coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   87.32%   87.34%   +0.02%     
==========================================
  Files          36       36              
  Lines        1207     1217      +10     
==========================================
+ Hits         1054     1063       +9     
- Misses        153      154       +1
Impacted Files Coverage Δ
src/JsonSchema/PhpBuilder.php 83.96% <ø> (ø) ⬆️
src/JsonSchema/SchemaBuilder.php 92.39% <83.33%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a618336...4b008df. Read the comment docs.

@vearutop
vearutop merged commit 39d2404 into master Sep 12, 2019
@vearutop
vearutop deleted the names-from-descriptions branch September 12, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant